cmake: always define TARGET_OS_* to 0 or 1
There is a system include file TargetConditionals.h on macOS, which defines TARGET_OS_LINUX (and others) to 0 or 1. On the other side, TARGET_OS_LINUX is also defined by trivia/config.h.cmake, but there it has another possible values: undefined or 1. This inconsistency causes issues like #8445, when TARGET_OS_LINUX is defined (to 0) in one file and undefined in another. Let's always define it to 0 or 1. Closes #8445 NO_DOC=bugfix
Showing
- changelogs/unreleased/gh-8445-crash-during-crash-report.md 4 additions, 0 deletionschangelogs/unreleased/gh-8445-crash-during-crash-report.md
- src/box/module_cache.c 1 addition, 1 deletionsrc/box/module_cache.c
- src/lib/core/crash.c 1 addition, 1 deletionsrc/lib/core/crash.c
- src/lib/core/crash.h 1 addition, 1 deletionsrc/lib/core/crash.h
- src/lib/core/fio.c 1 addition, 1 deletionsrc/lib/core/fio.c
- src/lib/core/popen.c 5 additions, 5 deletionssrc/lib/core/popen.c
- src/lib/core/say.c 1 addition, 1 deletionsrc/lib/core/say.c
- src/lib/core/sio.c 1 addition, 1 deletionsrc/lib/core/sio.c
- src/main.cc 3 additions, 3 deletionssrc/main.cc
- src/trivia/config.h.cmake 10 additions, 10 deletionssrc/trivia/config.h.cmake
- test/app-luatest/gh_8445_crash_during_crash_report_test.lua 54 additions, 0 deletionstest/app-luatest/gh_8445_crash_during_crash_report_test.lua
Loading
Please register or sign in to comment