Skip to content
Snippets Groups Projects
  • Igor Munkin's avatar
    e987aedb
    asan: enable ASan and LSan support for LuaJIT back · e987aedb
    Igor Munkin authored
    All LuaJIT related LSan warnings were suppressed in the scope of the
    commit 985548e4 ("asan: suppress all
    LSAN warnings related to LuaJIT"), since all compiler flags tweaks were
    enclosed in LuaJIT CMake machinery. As a result of the commit in LuaJIT
    submodule tarantool/luajit@a86e376 ("build: introduce LUAJIT_USE_ASAN
    option") ASan and LSan support has been finally added to LuaJIT runtime,
    so it was decided to remove LSan suppressions for LuaJIT functions.
    Unfortunately, it was not so easy as it looked like.
    
    At first, Lua global state is not closed properly at Tarantool instance
    exit (see <tarantool_free> in src/main.cc and <tarantool_lua_free> in
    src/lua/init.c for more info), so LSan false-positive leaks are detected
    (for more info, see #3071). Hence, the original LSan suppression for
    lj_BC_FUNCC is returned back (temporarily) until the aforementioned
    issue is not resolved.
    
    Furthermore, the internal LuaJIT memory allocator is not instrumented
    yet, so to find any memory faults it's worth building LuaJIT with system
    provided memory allocator (i.e. enable LUAJIT_USE_SYSMALLOC option).
    However, again, since Tarantool doesn't finalize Lua universe the right
    way, so running Tarantool testing routine with LUAJIT_USE_SYSMALLOC
    enabled generates false-positive LSan leaks. Return back here to enable
    LUAJIT_USE_SYSMALLOC, when #3071 is resolved.
    
    Last but not least, the default value of fiber stack size is 512Kb, but
    several tests in test/PUC-Rio-Lua-5.1-test suite in LuaJIT submodule
    (e.g. some cases with deep recursion in errors.lua or pm.lua) have
    already been tweaked according to the limitations mentioned in #5782,
    but the crashes still occur while running LuaJIT tests with ASan support
    enabled. Experiments once again confirm the notorious quote that "640 Kb
    ought to be enough for anybody".
    
    Anyway, LuaJIT tests are added to <test-release-asan> target in .test.mk
    and LUAJIT_TEST_ENV is extended with required ASan and LSan options.
    
    Follows up #5878
    
    NO_DOC=ci
    NO_TEST=ci
    NO_CHANGELOG=ci
    
    (cherry picked from commit bacf4e56)
    asan: enable ASan and LSan support for LuaJIT back
    Igor Munkin authored
    All LuaJIT related LSan warnings were suppressed in the scope of the
    commit 985548e4 ("asan: suppress all
    LSAN warnings related to LuaJIT"), since all compiler flags tweaks were
    enclosed in LuaJIT CMake machinery. As a result of the commit in LuaJIT
    submodule tarantool/luajit@a86e376 ("build: introduce LUAJIT_USE_ASAN
    option") ASan and LSan support has been finally added to LuaJIT runtime,
    so it was decided to remove LSan suppressions for LuaJIT functions.
    Unfortunately, it was not so easy as it looked like.
    
    At first, Lua global state is not closed properly at Tarantool instance
    exit (see <tarantool_free> in src/main.cc and <tarantool_lua_free> in
    src/lua/init.c for more info), so LSan false-positive leaks are detected
    (for more info, see #3071). Hence, the original LSan suppression for
    lj_BC_FUNCC is returned back (temporarily) until the aforementioned
    issue is not resolved.
    
    Furthermore, the internal LuaJIT memory allocator is not instrumented
    yet, so to find any memory faults it's worth building LuaJIT with system
    provided memory allocator (i.e. enable LUAJIT_USE_SYSMALLOC option).
    However, again, since Tarantool doesn't finalize Lua universe the right
    way, so running Tarantool testing routine with LUAJIT_USE_SYSMALLOC
    enabled generates false-positive LSan leaks. Return back here to enable
    LUAJIT_USE_SYSMALLOC, when #3071 is resolved.
    
    Last but not least, the default value of fiber stack size is 512Kb, but
    several tests in test/PUC-Rio-Lua-5.1-test suite in LuaJIT submodule
    (e.g. some cases with deep recursion in errors.lua or pm.lua) have
    already been tweaked according to the limitations mentioned in #5782,
    but the crashes still occur while running LuaJIT tests with ASan support
    enabled. Experiments once again confirm the notorious quote that "640 Kb
    ought to be enough for anybody".
    
    Anyway, LuaJIT tests are added to <test-release-asan> target in .test.mk
    and LUAJIT_TEST_ENV is extended with required ASan and LSan options.
    
    Follows up #5878
    
    NO_DOC=ci
    NO_TEST=ci
    NO_CHANGELOG=ci
    
    (cherry picked from commit bacf4e56)