Skip to content
Snippets Groups Projects

fix: return error instead of crashing on altering guest

Merged Егор Ивков requested to merge fix-set-pass into master
All threads resolved!

Summary

  • fix: return error instead of crashing on altering guest

  • refactor: perform access control checks at the start of proc_cas_local


  • Close #490 (closed)
  • Target branch: master
  • Changes should be cherry-picked to 23.12: no
  • Docs follow-up: not necessary
Edited by Егор Ивков

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 3 commits

    • 933b54da - 1 commit from branch master
    • 315a4cd5 - refactor: perform access control checks at the start of proc_cas_local
    • 7eb4b3ba - fix: return error instead of crashing on altering guest

    Compare with previous version

  • Changes should be cherry-picked to 23.12: yes / no

    It's unclear whether we should cherrypick this as the next version that we are planning to provide to consultants is planned to be 24.1

  • added 5 commits

    • 7eb4b3ba...47e1f2e2 - 3 commits from branch master
    • b892d7f2 - refactor: perform access control checks at the start of proc_cas_local
    • b27f7bcf - fix: return error instead of crashing on altering guest

    Compare with previous version

  • added 1 commit

    • 1de37c6f - refactor: check acl with transaction in cas

    Compare with previous version

  • Егор Ивков resolved all threads

    resolved all threads

  • Егор Ивков changed the description

    changed the description

  • added 1 commit

    • 35fe1ac3 - refactor: check acl with transaction in cas

    Compare with previous version

  • added 1 commit

    • d7ccee7e - fix: return error instead of crashing on altering guest

    Compare with previous version

  • added 4 commits

    • d7ccee7e...49622e83 - 2 commits from branch master
    • a464f27d - refactor: perform access control checks at the start of proc_cas_local
    • b90eef33 - fix: return error instead of crashing on altering guest

    Compare with previous version

  • added 6 commits

    • b90eef33...d1909b64 - 4 commits from branch master
    • 61f40526 - refactor: perform access control checks at the start of proc_cas_local
    • 0f2d8d3e - fix: return error instead of crashing on altering guest

    Compare with previous version

  • Yaroslav Dynnikov approved this merge request

    approved this merge request

  • Yaroslav Dynnikov added 4 commits

    added 4 commits

    • 0f2d8d3e...bfff1b4f - 2 commits from branch master
    • 6120f1c7 - refactor: perform access control checks at the start of proc_cas_local
    • e0702031 - fix: return error instead of crashing on altering guest

    Compare with previous version

  • Yaroslav Dynnikov enabled an automatic merge when the pipeline for e0702031 succeeds

    enabled an automatic merge when the pipeline for e0702031 succeeds

  • Please register or sign in to reply
    Loading