Skip to content
Snippets Groups Projects

feat(audit): fix broken instance-related events

Merged feat(audit): fix broken instance-related events
funbringer/audit-missing-things into master
Merged Dmitry Ivanov requested to merge funbringer/audit-missing-things into master

Summary

fix(audit): fix broken instance-related events

This patch reintroduces instance-related events (e.g. join_instance) which were accidentally disabled in a bugfix of the DML handler (see commit 52ed9237 for more information) due to the lack of tests.

Furthermore, this patch adds the following events:

  • expel_instance
  • change_config, which tracks changes in _pico_property

This was the original intended change of the patch, but the apparent breakage of the preexisting events called for action.

Part of #349 (closed)

Ensure that

  • New code is covered by tests
  • API is documented
  • Changelog is up to date
  • (if Lua API changed) Lua API version is bumped in luamod.rs
  • (if necessary) A follow-up doc issue is created in picodata/docs and linked here
Edited by Dmitry Ivanov

Merge request reports

Pipeline #28983 passed

Stage: test

Pipeline passed for f7c8d5aa on funbringer/audit-missing-things

Merged by Dmitry IvanovDmitry Ivanov 1 year ago (Dec 5, 2023 1:54pm UTC)

Loading

Pipeline #29091 passed

Stage: test

Pipeline passed for f7c8d5aa on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply