Skip to content
Snippets Groups Projects

fix: used to persist applied index before commit index

Merged Georgy Moshkin requested to merge gmoshkin/fix-commit-less-than-applied into master

Summary

  • fix: don't compact unapplied entries

  • test: implement basic error injection & add some tests for main loop

  • fix: used to persist applied index before commit index

This could result in a broken instance if it terminated in between the two storage writes. Now we always persist the commit index before applying the persisted entries and do so in a transaction with unstable entries or snapshot if they are present.

  • fix: minor tweaks

  • refactor: extract prepare_for_snapshot function

  • refactor: use a watch channel instead of Event::EntryApplied

Close #418 (closed)

Ensure that

  • New code is covered by tests
  • API is documented
  • Changelog is up to date
  • (if Lua API changed) Lua API version is bumped in luamod.rs
  • (if necessary) A follow-up doc issue is created in picodata/docs and linked here
Edited by Georgy Moshkin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading