Skip to content
Snippets Groups Projects

refactor: simplify raft entry proposal

Merged Georgy Moshkin requested to merge gmoshkin/refactor-entry-context into master

Summary

  • refactor: simplify raft entry proposal

    • remove logical clock from raft entry context, (term, index) is used for synchronization instead
    • this allows us to remove the Notify/Notifier boilerplate
    • NodeImpl::notifications -> NodeImpl::read_state_wakers
    • this and the recently refactored proc_join finally allows us to remove OpResult
    • ContextCoercion & CoercionError are also removed for the sake of simplification
  • fix: forbid direct proposal of entries on followers

    • removed method NodeImpl::propose (propose_async replaces it)
    • make NodeImpl::propose_async return Error on followers, only leader can propose entries directly, others should use CAS
    • remove all tests which used direct entry proposal on followers, they're not needed anymore
Edited by Yaroslav Dynnikov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Georgy Moshkin added 2 commits

    added 2 commits

    • faca599c - 1 commit from branch master
    • 8e261a88 - refactor: simplify raft entry proposal

    Compare with previous version

  • Georgy Moshkin changed the description

    changed the description

  • Georgy Moshkin marked this merge request as draft

    marked this merge request as draft

  • mentioned in issue #370 (closed)

  • mentioned in issue #367 (closed)

  • Georgy Moshkin added 200 commits

    added 200 commits

    Compare with previous version

  • Georgy Moshkin marked this merge request as ready

    marked this merge request as ready

  • Georgy Moshkin resolved all threads

    resolved all threads

  • Georgy Moshkin added 1 commit

    added 1 commit

    • 3963fb5e - fix: forbid direct proposal of entries on followers

    Compare with previous version

  • Georgy Moshkin resolved all threads

    resolved all threads

  • Georgy Moshkin changed the description

    changed the description

  • Georgy Moshkin added 3 commits

    added 3 commits

    • 933b54da - 1 commit from branch master
    • 6461f177 - refactor: simplify raft entry proposal
    • af852ff3 - fix: forbid direct proposal of entries on followers

    Compare with previous version

  • Yaroslav Dynnikov requested review from @rosik

    requested review from @rosik

  • Yaroslav Dynnikov changed the description

    changed the description

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading