Skip to content
Snippets Groups Projects

Add proper support for LDAP

Merged Dmitry Ivanov requested to merge funbringer/picodata-ldap-support into master
All threads resolved!

Previously, we implemented LDAP auth mechanism in core tarantool. This MR aims to add support for LDAP to picodata connect and a few other api methods, namely pico.create_user & pico.change_password. It also fixes a few bugs discovered in the progress.

Related: picodata/tarantool!82.

Edited by Dmitry Ivanov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @gmoshkin поревьюй тоже пожалуйста.

  • Yaroslav Dynnikov approved this merge request

    approved this merge request

  • Yaroslav Dynnikov requested review from @gmoshkin and removed review request for @rosik

    requested review from @gmoshkin and removed review request for @rosik

  • Кстати, https://git.picodata.io/picodata/picodata/picodata/-/blob/funbringer/picodata-ldap-support/src/schema.rs#L199

        pub enum AuthMethod {
            ChapSha1 = "chap-sha1",
            MD5 = "md5",
        }

    Это правильно?

  • Dmitry Ivanov added 4 commits

    added 4 commits

    • 47000b4c - fix: `picodata connect` eats error logs and exit codes
    • 552228a0 - fix: make `object_name` optional in `pico.grant_privilege`
    • b4f91018 - feat: Add `-a,--auth-type` to `picodata connect`
    • 04013134 - feat: Build picodata with LDAP support

    Compare with previous version

  • Dmitry Ivanov resolved all threads

    resolved all threads

  • Author Maintainer

    Это правильно?

    Потерял при ребейзах, вернул на место.

  • Georgy Moshkin approved this merge request

    approved this merge request

  • Dmitry Ivanov added 2 commits

    added 2 commits

    • e840abec - feat: Add `-a,--auth-type` to `picodata connect`
    • d0fea161 - feat: Build picodata with LDAP support

    Compare with previous version

  • Dmitry Ivanov added 2 commits

    added 2 commits

    • 173cc367 - feat: Add `-a,--auth-type` to `picodata connect`
    • 70f05827 - feat: Build picodata with LDAP support

    Compare with previous version

  • Dmitry Ivanov added 2 commits

    added 2 commits

    • 091caa22 - feat: Add `-a,--auth-type` to `picodata connect`
    • 9708f766 - feat: Build picodata with LDAP support

    Compare with previous version

  • Dmitry Ivanov added 8 commits

    added 8 commits

    • 9708f766...26da2901 - 4 commits from branch master
    • 62068ae5 - fix: `picodata connect` eats error logs and exit codes
    • 27dcf0fa - fix: make `object_name` optional in `pico.grant_privilege`
    • 23609fac - feat: Add `-a,--auth-type` to `picodata connect`
    • 77119d74 - feat: Build picodata with LDAP support

    Compare with previous version

  • merged

  • mentioned in issue #400 (closed)

  • Please register or sign in to reply
    Loading