Skip to content
Snippets Groups Projects

Check max users on user creation

Merged Егор Ивков requested to merge eivkov/check-max-users into master
All threads resolved!

Summary

  • fix: check max users on user creation

  • test: role and user limits

Due to the fact that we don't use two stage commit for ACL, we have to check all the ACL preconditions both in SQL preprocessing (as a short circuit) and in CAS (for consistency), also CAS can be called directly


  • Close #1208 (closed)
  • Cherry-pick to: none
  • Docs follow-up: not necessary
  • Changelog is updated
Edited by Егор Ивков

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dmitry Rodionov
  • Two minor comments. Do we explain 32 vs 26 in our docs?

  • Dmitry Rodionov approved this merge request

    approved this merge request

  • Do we explain 32 vs 26 in our docs?

    Yes

    Edited by Егор Ивков
  • added 21 commits

    Compare with previous version

  • Егор Ивков resolved all threads

    resolved all threads

  • Егор Ивков enabled an automatic merge when the pipeline for 63cc4ab8 succeeds

    enabled an automatic merge when the pipeline for 63cc4ab8 succeeds

  • Emir Vildanov aborted the automatic merge because target branch was updated

    aborted the automatic merge because target branch was updated

  • added 3 commits

    • 3bb6d155 - 1 commit from branch master
    • cb9702b0 - test: role and user limits
    • 9a52b0fd - fix: check max users on user creation

    Compare with previous version

  • Егор Ивков enabled an automatic merge when the pipeline for 9a52b0fd succeeds

    enabled an automatic merge when the pipeline for 9a52b0fd succeeds

  • Кирилл Безуглый aborted the automatic merge because target branch was updated

    aborted the automatic merge because target branch was updated

  • added 15 commits

    Compare with previous version

  • Егор Ивков resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading