test: cleanup cluster.cas vs instance.cas inconsistencies

Summary

• test: reduce test_log_rollback flakiness

• test: what was this about?

• test: cleanup cluster.cas vs instance.cas inconsistencies

Note that now we don't have any (is this right?) tests that use pico.cas which should be fine considering we plan to get rid of it in the near future.

Also we don't use password for cas operations, because the stored procedure can only be called by the superuser and the access control checks rely on the as_user parameter.

---

• Cherry-pick to: none
• Docs follow-up: not necessary

test/int/test_network_effects.py

 import pytest
 import time
 
-from conftest import Cluster, Instance, TarantoolError, Retriable
+from conftest import Cluster, Instance, TarantoolError, Retriable, ErrorCode
 
 
 @pytest.fixture
@@ -65,12 +65,32 @@ def test_log_rollback(cluster3: Cluster):
 
     key = 0
 
-    def propose_state_change(srv: Instance, value):
+    def propose_state_change(srv: Instance, value, timeout=10):
+        deadline = time.time() + timeout
         nonlocal key
-        index = cluster3.cas(
-            "insert", "_pico_property", (f"check{key}", value), instance=srv
-        )
-        srv.raft_wait_index(index)
+        while True:
+            try:
+                index = cluster3.cas(
+                    "insert",
+                    "_pico_property",
+                    (f"check{key}", value),
+                    instance=srv,
+                )
+                srv.raft_wait_index(index)
+                break
+            except TarantoolError as e:
+                print(f"\x1b[33m### CaS error: {e}", end="")
+                if time.time() > deadline:
+                    print(", timeout\x1b[0m")
+                    raise
+
+                if ErrorCode.is_retriable_for_cas(e.args[0]):
+                    print(", retrying...\x1b[0m")
+                    time.sleep(0.1)
+                    continue
+
+                print(", failure!\x1b[0m")
+                raise
         key += 1
 
     propose_state_change(i1, "i1 is a leader")