Skip to content
Snippets Groups Projects

fix(discovery): fix hanging if some peers don't respond

Merged Georgy Moshkin requested to merge fix/parallel-discovery into master
All threads resolved!

Previously the discovery algorithm would try to reach each known peer sequentially requiring each consequent request to succeed until the next one can be attempted. This would not work in some cases (see test in previous commit).

So the new algorithm instead makes a single attempt to reach each peer within a round, and if some failed they're retried in the next round of requests. This allows to overall discovery to succeed in cases when some of the initial peers never respond.

Closes #54 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sergey V
  • Sergey V
  • Sergey V
  • Sergey V
  • Georgy Moshkin added 2 commits

    added 2 commits

    • 39498cb6 - test: parallel discovery test (currently failing)
    • 785e2683 - fix(discovery): fix hanging if some peers don't respond

    Compare with previous version

  • Georgy Moshkin added 1 commit

    added 1 commit

    • fdb31625 - fix(discovery): fix hanging if some peers don't respond

    Compare with previous version

  • Georgy Moshkin added 1 commit

    added 1 commit

    • 4d3116b0 - fix(discovery): fix hanging if some peers don't respond

    Compare with previous version

  • Georgy Moshkin resolved all threads

    resolved all threads

  • Yaroslav Dynnikov requested review from @rosik

    requested review from @rosik

  • mentioned in issue #64 (closed)

  • Yaroslav Dynnikov resolved all threads

    resolved all threads

  • Yaroslav Dynnikov approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading