Skip to content
Snippets Groups Projects

fix: use Path and PathBuf by default in all configs and args

Merged Егор Ивков requested to merge eivkov/fix-admin-sock into master
All threads resolved!

Summary

  • fix: use Path and PathBuf by default in all configs and args

this fixes the following bug:

picodata run --data-dir tmp/i1/
C> invalid socket path: tmp/i1//admin.sock
[supervisor:214288] no ipc message from child
[supervisor:214288] subprocess 214289 exited with code 1

  • Close #634 (closed)
  • Cherry-pick to: 24.2, 24.3
  • Docs follow-up: not necessary
Edited by Егор Ивков

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 046ea944 - fix: use Path and PathBuf by default in all configs and args

    Compare with previous version

  • requested review from @funbringer

  • added 3 commits

    Compare with previous version

  • Егор Ивков marked this merge request as ready

    marked this merge request as ready

  • Dmitry Ivanov resolved all threads

    resolved all threads

  • Dmitry Ivanov approved this merge request

    approved this merge request

  • Yaroslav Dynnikov enabled an automatic merge when the pipeline for 6cd737a7 succeeds

    enabled an automatic merge when the pipeline for 6cd737a7 succeeds

  • Егор Ивков aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • added 1 commit

    • ef904506 - fix: use Path and PathBuf by default in all configs and args

    Compare with previous version

  • Егор Ивков enabled an automatic merge when the pipeline for ef904506 succeeds

    enabled an automatic merge when the pipeline for ef904506 succeeds

  • Егор Ивков changed the description

    changed the description

  • Егор Ивков canceled the automatic merge

    canceled the automatic merge

  • added 1 commit

    • 03252bd8 - fix: use Path and PathBuf by default in all configs and args

    Compare with previous version

  • Yaroslav Dynnikov changed milestone to %24.2.4

    changed milestone to %24.2.4

  • Yaroslav Dynnikov approved this merge request

    approved this merge request

  • Егор Ивков mentioned in merge request !1040 (merged)

    mentioned in merge request !1040 (merged)

  • Please register or sign in to reply
    Loading