- update sbroad submodule to commit with helper
patches for dml on global tables
- add support for sql dml insert/update/delete
on global tables. Insert on conflict is not
supported yet
- Current implementation uses a single batch of
dml commands via CAS. No additional predicates
are used in CAS, so no isolation level is guaranteed
even when query only refers to global tables

- rename it to proc_sql_dispatch
- modify args so that it's more suitable for public RPC API

Previously when running `pico.sql [[ create table foo ]]` we would get
this output:
```
---
- null
- "sbroad: rule parsing error:  --> 1:9\n  |\n1 |  create table foo \n  |  ^---\n
  \ |\n  = expected Unique"
...
```

But now the output will be:
```
---
- null
- |+
  sbroad: rule parsing error:  --> 1:9
    |
  1 |  create table foo
    |         ^---
    |
    = expected Unique

...
```

Maksim Kaitmazian authored 11 months ago and Dmitry Ivanov committed 9 months ago

The backend module implements the logic for handling postgres messages.
Note that this commit doesn't bring anything new: it just moves picodata's
handlers into pgproto.

This commit fixes that non-admin users can't read queries from the query cache.
An attempt to read from the cache used to result in the following error:
sbroad error: failed to get space_def: box error: AccessDenied: Read access to space '_pico_table' is denied for user 'alex3'

Previously, an error would occur when a user ran the same query twice.
During the first execution, the query was prepared and cached. However,
on the second execution, the client attempted to retrieve the query from the
cache and encountered an access denied error.

- we didn't check that index name is unique
in indexes meta table. That led to panics
when index with same name was created for
two tables.
- previous commit set wrong sbroad submodule.
Set sbroad submodule to correct commit

Fedor Telnov authored 11 months ago and Denis Smirnov committed 10 months ago

It syncs API with new sbroad's one.
For more context refer to sbroad!424

We have recently replaced String with SmolStr in sbroad.
As a result, we need to make corresponding changes in
picodata as it uses sbroad-core for cluster SQL.

BREAKING CHANGE: "name" index in the _pico_index has changed:
previously it guarantees uniqueness for a pair of (space_id,
index_name). Now index name must be unique among the cluster.
So, all the global indexes for _pico tables were renamed.

Make field 'auth' nullable

(cherry picked from commit 39f8885b)

- Update sbroad submodule to commit with
grant/revoke procedure support
- Use existing mechanisms for grant/revoke
ACL opcodes for grant/revoke procedure
implementation
- Add integration tests
- Valid combinations:

all procedures: grant/revoke create/execute/drop
specific procedure: grant/revoke execute/drop

- Syntax:

grant create procedure to alice option(timeout=3)
grant execute procedure on "spam"(int) to "alex"
grant drop procedure on foo to bob
revoke drop procedure on foo from bob

This commit introduces:
 * statement and portal storages;
 * statements with parameter oids;
 * portal encoding;
 * interactive portals;

Portal encoding defines in which format (binary or text) columns
are returned.

Interactive portals allow to limit the number of rows returned from
execute method. Other rows can be extracted by calling execute again
on the same portal.

- add new ddl opcode for renaming procedure
- update sbroad submodule to get sql support
- syntax:

alter procedure "foo" rename to "bar" option(timeout=3)
alter procedure "foo"(int, int) rename to "bar"

- Update sbroad submodule to commit,
with refactored tracing api: tracer
can be provided by library user (us).
- Use tracer that creates traces under
admin, because traces are created randomly
for 1% of the queries and the user may not
have the privileges to create/modify tracing
tables
- Move tracing related logic to picodata repo.
In particular, now all tables storing tracing
- Add sql tests that were removed from sbroad
during refactoring
- added extra parameter 'query_id' to pico.sql
lua api. 'query_id' is used to identify
each query in tracing tables, if not specified
hash function on query text is used.
- changed signature of pico.sql to:
pico.sql(pattern[, params, options)
options={'traceable'=boolean,'query_id'=string}

Current commit introduces
- _pico_routine replicated table
- procedure creation with SQL API

Egor Ivkov authored 1 year ago and Егор Ивков committed 1 year ago

Panic happened in `on_access_denied` trigger. There was a switch to admin and back to user with `su`. Switch back to user panicked in SuGuard drop as user did not have session privilege.