Introduce new parameters for alter system:
  - vdbe_max_steps
  - vtable_max_rows

Previously, LuaValue was used for deserializing msgpack data.
It is marked with #[serde(untagged)] attribute, meaning that
the enum is deserializaed by probing each variant in order unless one
succeeds. It turned out, that this can cause unexpected type convertions
due to the order of variants.

For example, msgpack integer value was deserialized into LuaValue::Double,
because this variant comes before LuaValue::Integer and integer values
can be represented as floats.

This commit resolves this issue by configuring LuaValue to be deserialized
as rmpv::Value using #[serde(try_from)] attribute.

Arseniy Volynets authored 5 months ago and Denis Smirnov committed 5 months ago

- update sbroad submodule to commit with fix

Note that after this merge request, we no longer validate whether the format
of the created object matches with the schema. Consequently, we do not
suppress errors if formats match anymore.

Before:
```sql
CREATE USER u WITH PASSWORD 'Passw0rd'
1
CREATE USER u WITH PASSWORD 'Passw0rd'
0
CREATE USER u WITH PASSWORD 'DifferentPassw0rd'
error: user already exists with different auth method
```

Now:
```sql
CREATE USER u WITH PASSWORD 'Passw0rd'
1
CREATE USER u WITH PASSWORD 'Passw0rd'
error: user u already exists
CREATE USER u WITH PASSWORD 'DifferentPassw0rd'
error: user u already exists
CREATE USER IF NOT EXISTS u WITH PASSWORD 'DifferentPassw0rd'
0
```

- In sql tests (test_limit) we encountered a bug,
when two different queries had the same hash
for executable subtree. We marked teset as xfail.
- The bug was caused by wrong calculation of hash
in sbroad. This was solved.
- Update sbroad submodule to commit with fix
- Remove xfail mark from test

This reverts commit 2924f112.

godzie44 authored 7 months ago and Georgy Moshkin committed 6 months ago

Closes #664

Changed sbroad vshard related traits and it's capabilities
about working with several vshard groups

This reverts commit d7e93cfc.

1. A better VDBE caching was implemented for local SQL.
2. Local SQL is called via C API rather then Lua.
3. A new prepare-unprepare fiber added to manage SQL statement
   cache.

feat: support ALTER SYSTEM. It allows to change whitelisted properties from _pico_property table. Currently, changes affect all tiers. Specifying tier will result in an error.

Co-Authored-by: Dmitry Rodionov <d.rodionov@picodata.io>

Co-Authored-by: Emir Vildanov <e.vildanov@picodata.io>

Arseniy Volynets authored 8 months ago and Arseniy Volynets committed 7 months ago

- update sbroad submodule to commit with
new normalization rules
- update integration tests