Dmitry Rodionov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

Before this patch we've had ADMIN_ID in schema.rs and ADMIN_USER_ID
in lib.rs. This patch removes ADMIN_USER_ID in favor of ADMIN_ID

Dmitry Rodionov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

At the later stage I discovered that sbroad applies the same validation
rules during parsing of grant/revoke statements and even its own
Privilege enum that is a ~copy of our PrivilegeType. Unfortunately
at the moment there is no way to share code between picodata and sbroad
efficiently (now only tarantool-module is shared and it is not suitable
for such kind of things) so it still makes sense to have this in
picodata because this is the point where all APIs converge to the single
point (CaS). In the future all other ways of validation should be
removed. Aside from sbroad similar kind of validation is performed
independently on lua API side.

Note that in prior commit 45ba7392 we've
removed all privileges from role super. This patch removes privileges
from admin that do not match the model: namely all privileges on
universe except session and usage. With this patch it is no longer possible
to grant or revoke such privileges.

Dmitry Rodionov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

This allows future constructors to enforce invariants.
Additionally this commit removes redundant set_schema_version on Op by
passing schema version to corresponding Op constructors.

This change allows for creators of corresponding objects to consequently have all privileges on them.

Rename space object type to table

Follow-up for bfe08313

Also fix some docstrings

Dmitry Rodionov authored 1 year ago and Yaroslav Dynnikov committed 1 year ago

It was previously used in luamod.rs in ops like create_space.
Its usage was replaced by reenterable_schema_change_request
in both Rust and Lua.

NB: this commit needs the fixes in tarantool-sys,
so we have to update the git submodule.

Adds support for creation of the sharded memtx spaces via pico.sql().

Georgy Moshkin authored 1 year ago and Georgy Moshkin committed 1 year ago

Closes #321