- Change error type
- Use add_of!() macro

It results in compilation warnings because of missing feature `mock`

I still don't like this version, because we now have at least 3
instantiations of stop_background_jobs, which is pretty massive. The
better solution would be to collect the iterators into a Vec and pass
the slice to the function, which would make it so the final binary only
has 1 version of it. But the source code is a little bit more readable
in the current version, and considering how nobody cares that picodata's
release binary weighs 166MB...

This change makes it so we don't have to lock the fiber mutex in some
cases.

Антон Фетисов authored 1 month ago and Антон Фетисов committed 1 month ago

This means that trailing SQL statements in multi-statement queries are no
longer silently ignored. We still allow trailing empty statements, since
they don't have any observable effect. Leading empty statements are still
not allowed. I don't think they are likely to be an issue in practice.

Антон Фетисов authored 1 month ago and Антон Фетисов committed 1 month ago

This fixes the `static-mut-refs` lint in sbroad.

When specifying the precision for localtimestamp, the digits to the right are zeroed out. However, if there were already zeros in those positions in the original value, the test may fail even when precisions are different. This can lead to flaky tests so test is removed.

EmirVildanov authored 1 month ago and Dmitry Ivanov committed 1 month ago

printlns were previously used in order to fix expected explain
more easily, this commit removes them and also refactors some code

EmirVildanov authored 1 month ago and Dmitry Ivanov committed 1 month ago

Before this commit we wasn't recalculating types after parameters
binding. This commit add additional tree traversal in order to fix it.

EmirVildanov authored 1 month ago and Dmitry Ivanov committed 1 month ago

Previously we were mistakenly giving default Integer type
to the Null value or to the column with no type. This commit
fixes such behavior and also adds support for type absence
during its calculation on SQL expressions

Denis Smirnov authored 2 months ago and Dmitry Ivanov committed 1 month ago

Stop using tarantool types in virtual table columns and derive them
from IR plan.

* fae9c5bbe fix: timeouts for on_shutdown fibers used to be computed incorrectly
* e2911d68e feat: auto set box.cfg{checkpoint_enabled=false} on split-brain
* 4cd0b4ae0 feat: add box.cfg.checkpoint_enabled to toggle snapshots on/off
* 3352da865 fix: ssl iostream used to return errors without setting them via diag_set
* cdf7a646d fix: drop WAL directory lock upon exec()

Антон Фетисов authored 1 month ago and Антон Фетисов committed 1 month ago

Criterion 0.5 has disabled default features of Clap, but those include help & usage messages.
Added Clap to explicit dependencies with default features, so that it works properly for benches.

Kurdakov Alexander authored 1 month ago and Alexander Kurdakov committed 1 month ago

Since it's deprecated option, it should not appear anywhere
except of explicit user intention.

Антон Фетисов authored 1 month ago and Dmitry Ivanov committed 1 month ago

Closes #1085
Closes #1084

Виталий Шунков authored 1 month ago and Виталий Шунков committed 1 month ago

fix: rule for build-base-image

Антон Фетисов authored 1 month ago and Антон Фетисов committed 1 month ago

This reduces build errors for sbroad tests when the `mock` feature isn't enabled.
This doesn't fully fix the build, linking still fails with an error (strange, tarantool-module
is listed in dev dependencies, but somewhy isn't linked properly). However, at least there are
fewer errors now.

cfg(test) on inner test modules is useless, since the containing module is already conditionally
included.

 - checkpoint_interval
 - checkpoint_count
 - max_concurrent_messages

max_concurrent_messages were renamed to iproto_net_msg_max