Skip to content
Snippets Groups Projects
Verified Commit f15778cf authored by Yaroslav Dynnikov's avatar Yaroslav Dynnikov
Browse files

chore: pleasure clippy

```console
$ cargo clippy
   Compiling picodata v0.1.0 (/home/rosik/w/picodata)
warning: 'tarantool-sys/patches-applied' exists, so patching step is
skipped
warning: single-character string constant used as pattern
   --> src/args.rs:194:47
    |
194 |     let (host, port) = match text.rsplit_once(":") {
    |                                               ^^^ help: try using
a `char` instead: `':'`
    |
    = note: `#[warn(clippy::single_char_pattern)]` on by default
    = help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern

warning: called `cloned().next()` on an `Iterator`. It may be more
efficient to call `next().cloned()` instead
   --> src/discovery.rs:154:27
    |
154 |                 let res =
    peers.difference(&self.visited).cloned().next();
    |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this:
`peers.difference(&self.visited).next().cloned()`
    |
    = note: `#[warn(clippy::iter_overeager_cloned)]` on by default
    = help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned

warning: you seem to be trying to use `match` for destructuring a single
pattern. Consider using `if let`
  --> src/ipc.rs:27:9
   |
27 | /         match rmp_serde::encode::write(&mut self.fd, msg) {
28 | |             Err(e) => tlog!(Error, "ipc error: {e}"),
29 | |             Ok(()) => (),
30 | |         }
   | |_________^ help: try this: `if let Err(e) =
rmp_serde::encode::write(&mut self.fd, msg) { tlog!(Error, "ipc error:
{e}") }`
   |
   = note: `#[warn(clippy::single_match)]` on by default
   = help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#single_match

warning: `picodata` (bin "picodata") generated 3 warnings
    Finished dev [unoptimized + debuginfo] target(s) in 1.41s
```
parent 1d5fca3a
No related branches found
No related tags found
1 merge request!71Fair raft join
Pipeline #3968 passed
...@@ -191,7 +191,7 @@ impl Display for BadAddress { ...@@ -191,7 +191,7 @@ impl Display for BadAddress {
} }
fn try_parse_address(text: &str) -> Result<String, Box<dyn Error>> { fn try_parse_address(text: &str) -> Result<String, Box<dyn Error>> {
let (host, port) = match text.rsplit_once(":") { let (host, port) = match text.rsplit_once(':') {
Some((mut host, port)) => { Some((mut host, port)) => {
if host.is_empty() { if host.is_empty() {
host = "localhost"; host = "localhost";
......
...@@ -151,7 +151,7 @@ impl Discovery { ...@@ -151,7 +151,7 @@ impl Discovery {
if self.pending_request { if self.pending_request {
return None; return None;
} }
let res = peers.difference(&self.visited).cloned().next(); let res = peers.difference(&self.visited).next().cloned();
let addr = match &res { let addr = match &res {
Some(addr) => { Some(addr) => {
self.visited.insert(addr.clone()); self.visited.insert(addr.clone());
......
...@@ -24,9 +24,8 @@ where ...@@ -24,9 +24,8 @@ where
T: Serialize, T: Serialize,
{ {
pub fn send(mut self, msg: &T) { pub fn send(mut self, msg: &T) {
match rmp_serde::encode::write(&mut self.fd, msg) { if let Err(e) = rmp_serde::encode::write(&mut self.fd, msg) {
Err(e) => tlog!(Error, "ipc error: {e}"), tlog!(Error, "ipc error: {e}")
Ok(()) => (),
} }
} }
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment