Skip to content
Snippets Groups Projects
Commit e3dc8a74 authored by Georgy Moshkin's avatar Georgy Moshkin :speech_balloon:
Browse files

chore: more TODOs

parent 5ef02e64
No related branches found
No related tags found
1 merge request!516OpDdl create space
......@@ -968,6 +968,7 @@ impl NodeImpl {
name: "primary_key".into(),
space_id: id,
schema_version,
// TODO: fill up parts with defaults/stuff we know
parts: primary_key,
operable: false,
// TODO: support other cases
......
......@@ -33,6 +33,9 @@ crate::define_rpc_request! {
let rc = unsafe { ffi::box_txn_begin() };
assert_eq!(rc, 0, "we're not in a transaction currently");
// TODO: transaction may have already started, if we're in a process of
// creating a big index. If governor sends a repeat rpc request to us we
// should handle this correctly
let res = apply_schema_change(storage, &ddl, pending_schema_version);
match res {
Ok(Response::Abort { .. }) | Err(_) => {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment