Skip to content
Snippets Groups Projects
Commit b7ef4e50 authored by Yaroslav Dynnikov's avatar Yaroslav Dynnikov
Browse files

feature: rename --advertise-address -> --advertise

parent 7043fed3
No related branches found
No related tags found
1 merge request!141Revise args
......@@ -55,12 +55,13 @@ pub struct Run {
pub instance_id: String,
#[clap(
long,
long = "advertise",
value_name = "[host][:port]",
env = "PICODATA_ADVERTISE_ADDRESS",
env = "PICODATA_ADVERTISE",
parse(try_from_str = try_parse_address)
)]
/// Address the other instances should use to connect to this instance
/// Address the other instances should use to connect to this instance.
/// Defaults to `--listen` value.
pub advertise_address: Option<String>,
#[clap(
......@@ -302,7 +303,7 @@ mod tests {
assert_eq!(parsed.advertise_address(), "listen-from-args:3301");
}
std::env::set_var("PICODATA_ADVERTISE_ADDRESS", "advertise-from-env");
std::env::set_var("PICODATA_ADVERTISE", "advertise-from-env");
{
let parsed = parse![Run,];
assert_eq!(parsed.listen, "listen-from-env:3301");
......@@ -312,7 +313,7 @@ mod tests {
assert_eq!(parsed.listen, "listen-from-args:3301");
assert_eq!(parsed.advertise_address(), "advertise-from-env:3301");
let parsed = parse![Run, "--advertise-address", "advertise-from-args"];
let parsed = parse![Run, "--advertise", "advertise-from-args"];
assert_eq!(parsed.listen, "listen-from-env:3301");
assert_eq!(parsed.advertise_address(), "advertise-from-args:3301");
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment