Skip to content

fix: drop WAL directory lock upon exec()

Dmitry Ivanovrequested to merge
funbringer/wal-flock-cloexec into 2.11.5-picodata

Summary

  • fix: drop WAL directory lock upon exec()

Previously, we'd preserve WAL directory lock during exec(), meaning that stray child processes would not let us restart the instance:

E> ER_ALREADY_RUNNING: Failed to lock WAL directory /data and hot_standby mode is off
F> can't initialize storage: Failed to lock WAL directory /data and hot_standby mode is off

This patch fixes that by setting O_CLOEXEC for the fd used in flock().

NO_DOC=internal NO_TEST=internal NO_CHANGELOG=internal

Close #72 (closed) Docs follow-up: not necessary / new issue

Edited by Dmitry Rodionov

Merge request reports