Skip to content

fix: ssl iostream used to return errors without setting them via diag_set

Maksim Kaitmazian requested to merge max/fix-ssl-luatest/replication_test.lua into 2.11.2-picodata

Summary

  • fix: ssl iostream used to return errors without setting them via diag_set

ssl-luatest/replication_test.lua used to fail because there was no error set in diag. Actually, the error was set, but in another fiber.

The erroneous scenario was as follows:

  1. A fatal error occurs in one fiber, this fiber poisons iostream with SSL_IOSTREAM_POISON flag and reports the error using diag_set. This operation fails with an error reported.
  2. Another fiber starts a new operation and discovers that SSL_IOSTREAM_POISON is set, so it returns IOSTREAM_ERROR early. However, the error was set only in another fiber, not in this one (errors are fiber local), so diag_raise fails on the assertion.

This commit resolves this problem by storing the error caused poisoning, so poisoned iostream can report this error to any fiber, that attempts to use it.

Closes picodata#890.

NO_DOC=internal NO_TEST=internal NO_CHANGELOG=internal

Docs follow-up: not necessary

Merge request reports