Skip to content

fix(picodata): don't close stderr & stdout in log_destroy

Dmitry Ivanov requested to merge funbringer/2.11.2-log-destroy-dont-close-stderr into 2.11.2-picodata

Summary

  • fix(picodata): don't close stderr & stdout in log_destroy

Previously, log_destroy would close log->fd even if it's one of the standard streams. This behavior almost never makes sense, unless one's trying to write a unix daemon which is obviously not the case.

Closing stderr has the following side effects:

  • it breaks a reinit of the default logger;
  • it inhibits ASan's final leak report;
  • it causes a EPOLLHUP during a restart via --entrypoint-fd (Picodata).

NO_DOC=internal NO_TEST=internal NO_CHANGELOG=internal

Close #... Docs follow-up: not necessary / new issue

Merge request reports