Skip to content
Snippets Groups Projects

refactor(cbus):

Merged Konstantin D requested to merge fix/cbus_lcpipe_race into master

Summary

  • refactor(cbus):
  • now LCPipe::push_message signature requires &mut self, cause write into LCPipe is not thread safe
  • remove oneshot::channel_on_pipe function
  • create a unique LCPipe instance for each unbounded::Sender instead of share single LCPipe by arc (also related to #156 (closed))
  • use a weak reference on unbounded::Waker in unbounded::Sender to prevent situation when waker dropped in non cord thread

Ensure that

  • New code is covered by tests
  • API is documented
  • Changelog is up to date
  • Version is bumped in the appropriate Cargo.toml files

Merge request reports

Checking pipeline status.

Merged by Konstantin DKonstantin D 1 year ago (Oct 24, 2023 8:22am UTC)

Loading

Pipeline #25906 passed

Pipeline passed for 5a062f41 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading