Skip to content

fix: used to panic on different values rows len

Arseniy Volynets requested to merge av/fix-values-panic into main

Summarize the changes

  • fix: used to panic on different values rows len
  • When creating Values node in IR we didn't check that all values rows have the same length.
  • This led to panic on earlier pipeline stages: syntax plan build
  • Add a check that all values rows have the same length

Ensure that

  • New code is covered by unit and integration tests.
  • Related issues would be automatically closed with gitlab's closing pattern (Closes #1, #2).
  • Public modules are documented (check the rendered version with cargo doc --open).
  • (if PEST grammar is changed) EBNF grammar reflects these changes (check the result with railroad diagram generator.

close #759 (closed)

Next steps

Merge request reports