Draft: String storage

Summarize the changes

• Minor fixup

• Add hashmap creation benchmark for plan with multiple same aliases

• Add cast overflow check

• Implement string storage for strings used in Plan

Ensure that

• New code is covered by unit and integration tests.
• Related issues would be automatically closed with gitlab's closing pattern (Closes #1, #2).
• Public modules are documented (check the rendered version with cargo doc --open).
• (if PEST grammar is changed) EBNF grammar reflects these changes (check the result with railroad diagram generator.

Next steps

• Update sbroad submodule in picodata/picodata.
• (if EBNF grammar is changed) create a follow-up issue in picodata/docs.

assigned to @andrewio

added 1 commit

• 3130ca49 - Change Rc<String> to SmolStr in Expression::Alias

Compare with previous version

added 1 commit

• be06d31f - Modify tests

Compare with previous version

added 1 commit

• 7e2bcd7e - Add new tests

Compare with previous version

added 1 commit

• 1917e2d1 - Change Expression::Alias name field type to u16

Compare with previous version

added 1 commit

• 3d9b7a03 - Minor fixup v2

Compare with previous version

added 36 commits

• 3d9b7a03...a81f6290 - 26 earlier commits
• 5739b0e5 - Implement string storage for strings used in Plan
• cdf749ea - Add cast overflow check
• 8fa1353c - Add hashmap creation benchmark for plan with multiple same aliases
• c8aed15a - Minor fixup
• a38b2c35 - Change Rc<String> to SmolStr in Expression::Alias
• 99130b47 - Modify tests
• 2fc96fe4 - Add new tests
• 18ebc229 - Change Expression::Alias name field type to u16
• 4dfad31b - Minor fixup v2
• 112e2653 - Remove map field from StringStorage

Compare with previous version

added 1 commit

• eda1614f - Omit hashmap serialization and add deserialization tests

Compare with previous version

added 1 commit

• e08d28e4 - Replace Vec with SmallVec

Compare with previous version

marked this merge request as draft

closed