Skip to content
Snippets Groups Projects

chore: use -rdynamic instead of -export-dynamic

Merged Dmitry Rodionov requested to merge dkr/export-dynamic-on-fedora into master

Summary

  • chore: use -rdynamic instead of -export-dynamic

It has been observed that on Fedora -export-dynamic triggers some reincarnation of this bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47390

TLDR: it treated leading -e as entrypoint argument so resulting binary was completely broken, i e there was no main in it and entrypoint was set to unrelated deregister_tm_clones. Big thanks to @gmoshkin for finding the solution and to @funbringer for assistance with debugging

Ensure that

  • New code is covered by tests
  • API is documented
  • Changelog is up to date
  • (if Lua API changed) Lua API version is bumped in luamod.rs
  • (if necessary) A follow-up doc issue is created in picodata/docs and linked here

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading