Skip to content

Draft: fix: do not update max_id in _schema on space creation

Denis Smirnov requested to merge fix_schema_max_id into master

Summary

  • fix: do not update max_id in _schema on space creation

The system space _schema in picodata contains a tweaked version of the max_id = 1024. It works a a watermark that separates system and internal picodata spaces from the user ones. So, there is no reason to increment this value on the user space insertion as we did it before. Moreover, such updates are doomed to produce different data races as we need to unsert tuples in the journaled system spaces (_space and _schema) and each separate insertion produces yield. So, max_id should never be updated other then on the instance initialization.

Close sbroad#537 (closed)

Depends on tarantool-module!411 (closed)

Blocked by tarantool-module#164 (closed)

Ensure that

  • New code is covered by tests
  • API is documented
  • Changelog is up to date
  • (if Lua API changed) Lua API version is bumped in luamod.rs
  • (if necessary) A follow-up doc issue is created in picodata/docs and linked here
Edited by Denis Smirnov

Merge request reports