Skip to content

chore: unify protobuf features

Dmitry Rodionov requested to merge dkr/unify-protobuf-features into master

Summary

  • chore: unify protobuf features

Before this change we were building protobuf twice with different set of features being enabled.

Part of cargo build --timings output before this change:

protobuf v2.28.0 3.3s 1.5s (46%) bytes

protobuf v2.28.0 2.6s 0.7s (27%) bytes, with-bytes

With this patch duplication is removed

Ensure that

  • New code is covered by tests
  • API is documented
  • Changelog is up to date
  • (if Lua API changed) Lua API version is bumped in luamod.rs
  • (if necessary) A follow-up doc issue is created in picodata/docs and linked here
Edited by Dmitry Rodionov

Merge request reports