Skip to content
Snippets Groups Projects

Feat/voter switchover

Merged Georgy Moshkin requested to merge feat/voter-switchover into refactor-join-loop-2
1 unresolved thread

goes after !162 (merged)

Merge request reports

Merge request pipeline #7492 failed

Merge request pipeline failed for 46567ebc

Approval is optional

Merged by Yaroslav DynnikovYaroslav Dynnikov 2 years ago (Jul 1, 2022 1:16pm UTC)

Merge details

  • Changes merged into master with 46567ebc.
  • Deleted the source branch.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
480 482 _ => unreachable!(),
481 483 };
482 484
485 let raft_id = &raw_node.raft.id;
486 let voters_old = Storage::voters().unwrap();
487 if voters_old.contains(raft_id) && !conf_state.voters.contains(raft_id) {
488 event::postpone_until(Event::Demoted, Event::LeaveJointState).ok();
489 }
490
  • Comment on lines +487 to +490

    Коварная фича. Конкретно в этом сценарии она вроде сделает свое дело, но тут есть о чем подумать. Например если инстанс рестартанет сразу после постпоуна, то после рестарта LeaveJointState рано или поздно случится, а Demoted - уже нет.

  • Author Maintainer

    добавил коммент про это

  • Please register or sign in to reply
  • Georgy Moshkin added 3 commits

    added 3 commits

    • 0a1c150f - refactor: use events instead of conds
    • c693710f - chore: fix warnings
    • 46567ebc - feat(switchover): implement voter switchover rules

    Compare with previous version

  • Please register or sign in to reply
    Loading