Skip to content

fix: RouteBuilder::register now only supports Fn, not FnMut

Georgy Moshkin requested to merge gmoshkin/fix-use-after-free-in-plugin-rpc into master

Summary

  • test: add tests for the previous fixes

  • fix: FfiSafe{Bytes, Str}::into_raw_parts tweaks

  • fix: RouteBuilder::register now only supports Fn, not FnMut

See doc comments for RouteBuilder::register, but TL;DR it's never safe to wrap a yielding function in a FnMut. The user should instead do the regular internal mutability thing.

  • fix: used to allow use after free in RPC handlers sometimes

  • fix: used to drop the closure after first call to plugin RPC handler

  • Cherry-pick to: none
  • Docs follow-up: not necessary
Edited by Georgy Moshkin

Merge request reports