diff --git a/src/box/errcode.h b/src/box/errcode.h index d234d26c856bfb447bc5d7f7ef94573d05b720cb..7764aa352ef3f02092322a9fc2145c7d2a9a3376 100644 --- a/src/box/errcode.h +++ b/src/box/errcode.h @@ -239,6 +239,7 @@ struct errcode_record { /*184 */_(ER_SQL_UNRECOGNIZED_SYNTAX, "Syntax error near '%.*s'") \ /*185 */_(ER_SQL_UNKNOWN_TOKEN, "Syntax error: unrecognized token: '%.*s'") \ /*186 */_(ER_SQL_PARSER_GENERIC, "%s") \ + /*187 */_(ER_SQL_ANALYZE_ARGUMENT, "ANALYZE statement argument %s is not a base table") \ /* * !IMPORTANT! Please follow instructions at start of the file diff --git a/src/box/sql/analyze.c b/src/box/sql/analyze.c index f95b34b609e7903c85f6e87d8c112cbf0c6bdd26..6ea598c1391617c5fb20c8494cb3b8a6dfc37af2 100644 --- a/src/box/sql/analyze.c +++ b/src/box/sql/analyze.c @@ -1121,9 +1121,10 @@ sqlAnalyze(Parse * pParse, Token * pName) struct space *sp = space_by_name(z); if (sp != NULL) { if (sp->def->opts.is_view) { - sqlErrorMsg(pParse, "VIEW isn't "\ - "allowed to be "\ - "analyzed"); + diag_set(ClientError, + ER_SQL_ANALYZE_ARGUMENT, + sp->def->name); + pParse->is_aborted = true; } else { vdbe_emit_analyze_table(pParse, sp); } diff --git a/src/box/sql/select.c b/src/box/sql/select.c index e83b89828187d199b6c5f2a8ddee0081389f0a42..5195656afe454564213f3206328a44eb8a194c31 100644 --- a/src/box/sql/select.c +++ b/src/box/sql/select.c @@ -407,8 +407,9 @@ sqlJoinType(Parse * pParse, Token * pA, Token * pB, Token * pC) jointype = JT_INNER; } else if ((jointype & JT_OUTER) != 0 && (jointype & (JT_LEFT | JT_RIGHT)) != JT_LEFT) { - sqlErrorMsg(pParse, - "RIGHT and FULL OUTER JOINs are not currently supported"); + diag_set(ClientError, ER_UNSUPPORTED, "Tarantool", + "RIGHT and FULL OUTER JOINs"); + pParse->is_aborted = true; jointype = JT_INNER; } return jointype; @@ -2465,8 +2466,9 @@ generateWithRecursiveQuery(Parse * pParse, /* Parsing context */ * the value for the recursive-table. Store the results in the Queue. */ if (p->selFlags & SF_Aggregate) { - sqlErrorMsg(pParse, - "recursive aggregate queries not supported"); + diag_set(ClientError, ER_UNSUPPORTED, "Tarantool", + "recursive aggregate queries"); + pParse->is_aborted = true; } else { p->pPrior = 0; sqlSelect(pParse, p, &destQueue); diff --git a/test/box/misc.result b/test/box/misc.result index 9f0b2c73ac7db6fd61ba910419c31e5882ae8205..c350bbd739c634413fc16ef7ec72509e9cb1902f 100644 --- a/test/box/misc.result +++ b/test/box/misc.result @@ -515,6 +515,7 @@ t; 184: box.error.SQL_UNRECOGNIZED_SYNTAX 185: box.error.SQL_UNKNOWN_TOKEN 186: box.error.SQL_PARSER_GENERIC + 187: box.error.SQL_ANALYZE_ARGUMENT ... test_run:cmd("setopt delimiter ''"); --- diff --git a/test/sql-tap/analyzeD.test.lua b/test/sql-tap/analyzeD.test.lua index 82ad7ff08d84f2e108ea9b8171f82168f36e9a5d..1f00e80e0bf54b43d79387cba9e3931d24a006be 100755 --- a/test/sql-tap/analyzeD.test.lua +++ b/test/sql-tap/analyzeD.test.lua @@ -177,7 +177,7 @@ test:do_catchsql_test( ANALYZE v; ]], { -- <analyzeD-1.12> - 1, "VIEW isn't allowed to be analyzed" + 1, "ANALYZE statement argument V is not a base table" -- <analyzeD-1.12> }) diff --git a/test/sql-tap/join.test.lua b/test/sql-tap/join.test.lua index df272a9e14d9cb45bff54341a8b221b64088189a..da29f77b136553d318ad38f8b8478f901326419e 100755 --- a/test/sql-tap/join.test.lua +++ b/test/sql-tap/join.test.lua @@ -480,7 +480,7 @@ test:do_catchsql_test( SELECT * FROM t1 NATURAL RIGHT OUTER JOIN t2; ]], { -- <join-2.3> - 1, "RIGHT and FULL OUTER JOINs are not currently supported" + 1, "Tarantool does not support RIGHT and FULL OUTER JOINs" -- </join-2.3> }) diff --git a/test/sql-tap/with1.test.lua b/test/sql-tap/with1.test.lua index add23455cf3f49af2269cdf530883f54b9b90d41..16c9b1207e275cd805b6f9d567c4d2994c8f5b2d 100755 --- a/test/sql-tap/with1.test.lua +++ b/test/sql-tap/with1.test.lua @@ -1065,7 +1065,7 @@ test:do_catchsql_test(16.1, [[ SELECT * FROM i; ]], { -- <16.1> - 1, "recursive aggregate queries not supported" + 1, "Tarantool does not support recursive aggregate queries" -- </16.1> })