From b766a14b9ec85f791790189c2b19f6563134588a Mon Sep 17 00:00:00 2001
From: Kaimtazian Maksim <m.kaitmazian@picodata.io>
Date: Thu, 20 Jul 2023 12:49:32 +0300
Subject: [PATCH] fix: box.schema.user.passwd doesn't change the password
box.schema.user.passwd doesn't change the password for the current
user because new password is passed instead of the user name.
NO_CHANGELOG=fix an unreleased bug
NO_DOC=fix an unreleased bug
---
src/box/lua/schema.lua | 3 +-
...nstead-of-user-name-in-box-passwd_test.lua | 28 +++++++++++++++++++
2 files changed, 30 insertions(+), 1 deletion(-)
create mode 100644 test/box-luatest/fix-passing-password-instead-of-user-name-in-box-passwd_test.lua
diff --git a/src/box/lua/schema.lua b/src/box/lua/schema.lua
index 3bfd430acf..ea072a4562 100644
--- a/src/box/lua/schema.lua
+++ b/src/box/lua/schema.lua
@@ -3242,7 +3242,8 @@ box.schema.user.passwd = function(name, new_password)
if new_password == nil then
-- change password for current user
new_password = name
- box.session.su('admin', chpasswd, session.uid(), new_password, name)
+ box.session.su('admin', chpasswd, session.uid(), new_password,
+ session.user())
else
-- change password for other user
local uid = user_resolve(name)
diff --git a/test/box-luatest/fix-passing-password-instead-of-user-name-in-box-passwd_test.lua b/test/box-luatest/fix-passing-password-instead-of-user-name-in-box-passwd_test.lua
new file mode 100644
index 0000000000..80193dbdde
--- /dev/null
+++ b/test/box-luatest/fix-passing-password-instead-of-user-name-in-box-passwd_test.lua
@@ -0,0 +1,28 @@
+local server = require('luatest.server')
+local t = require('luatest')
+
+local g = t.group()
+
+g.before_all(function()
+ g.server = server:new({alias = 'master'})
+ g.server:start()
+end)
+
+g.after_all(function()
+ g.server:stop()
+end)
+
+g.test_box_password_without_username_argument = function()
+ t.assert(g.server:exec(function()
+ box.cfg{auth_type='md5'}
+ local user = 'admin'
+ local pass = 'dwsadwaeaDSdawDsa321_#!$'
+ box.session.su(user)
+ local hash = box.space._user:select(1)[1][5]['md5']
+ t.assert_not_equals (hash, box.schema.user.password(pass, user))
+ box.schema.user.passwd(pass)
+ hash = box.space._user:select(1)[1][5]['md5']
+ t.assert_equals(hash, box.schema.user.password(pass, user))
+ return true
+ end))
+end
--
GitLab