From 90265328e59afd1598dc116424c6dcf11769415f Mon Sep 17 00:00:00 2001
From: Sergey Bronnikov <sergeyb@tarantool.org>
Date: Wed, 20 Jan 2021 14:24:25 +0000
Subject: [PATCH] test: fix luacheck warnings W212 in test/sql-tap
W212 (Unused argument)
Part of #5464
---
.luacheckrc | 2 --
test/sql-tap/e_expr.test.lua | 4 ++--
test/sql-tap/identifier-characters.test.lua | 2 +-
test/sql-tap/lua/sqltester.lua | 2 +-
test/sql-tap/sort.test.lua | 2 +-
5 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/.luacheckrc b/.luacheckrc
index 25970a8ef4..00098afe3b 100644
--- a/.luacheckrc
+++ b/.luacheckrc
@@ -49,8 +49,6 @@ exclude_files = {
files["test/sql-tap/**/*.lua"] = {
ignore = {
- -- Unused argument.
- "212",
-- Unused loop variable.
"213",
-- Local variable is set but never accessed.
diff --git a/test/sql-tap/e_expr.test.lua b/test/sql-tap/e_expr.test.lua
index 67c8579627..f9cfadbca9 100755
--- a/test/sql-tap/e_expr.test.lua
+++ b/test/sql-tap/e_expr.test.lua
@@ -1077,7 +1077,7 @@ test:do_execsql_test(
--
-- MUST_WORK_TEST prepared statements
if (0>0) then
- local function parameter_test(tn, sql, params, result)
+ local function parameter_test(tn, sql, params, result) -- luacheck: no unused
-- Legacy from the original code. Must be replaced with analogue
-- functions from box.
local X = nil
@@ -1286,7 +1286,7 @@ test:do_execsql_test(
test:execsql [[
CREATE TABLE tblname(cname INT PRIMARY KEY);
]]
-local function glob(args)
+local function glob()
return 1
end
diff --git a/test/sql-tap/identifier-characters.test.lua b/test/sql-tap/identifier-characters.test.lua
index 7b257921df..184916bd3e 100755
--- a/test/sql-tap/identifier-characters.test.lua
+++ b/test/sql-tap/identifier-characters.test.lua
@@ -65,7 +65,7 @@ local testcases = {
test:execsql("commit")
if ok == false then error(res) end
end,
- function (id) end},
+ function () end},
{"trigger name",
function (id)
test:execsql(string.format([[
diff --git a/test/sql-tap/lua/sqltester.lua b/test/sql-tap/lua/sqltester.lua
index 4ae80c0267..34ffad476e 100644
--- a/test/sql-tap/lua/sqltester.lua
+++ b/test/sql-tap/lua/sqltester.lua
@@ -179,7 +179,7 @@ local function execsql(self, sql)
end
test.execsql = execsql
-local function catchsql(self, sql, expect)
+local function catchsql(self, sql)
local r = {pcall(execsql, self, sql) }
if r[1] == true then
r[1] = 0
diff --git a/test/sql-tap/sort.test.lua b/test/sql-tap/sort.test.lua
index 6ccb993921..b28bba0e5c 100755
--- a/test/sql-tap/sort.test.lua
+++ b/test/sql-tap/sort.test.lua
@@ -763,7 +763,7 @@ if (0 > 0) then
-- Legacy from the original code. Must be replaced with analogue
-- functions from box.
local X = nil
-local function cksum(x)
+local function cksum(x) -- luacheck: no unused
local i1 = 1
local i2 = 2
X(503, "X!cmd", [=[["binary","scan",["x"],"c*","L"]]=])
--
GitLab