From 856b4c3c1c666288cd2b4cec5a8c1382dcfcae8d Mon Sep 17 00:00:00 2001
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Date: Sun, 15 Mar 2020 18:35:16 +0100
Subject: [PATCH] sql: trust column duplicate check to box
CREATE TABLE used to check column name duplicates before going to
box. But it is not necessary, because the same check is done by
box.
Reviewed-by: Nikita Pettik <korablev@tarantool.org>
---
src/box/sql/build.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/src/box/sql/build.c b/src/box/sql/build.c
index fbfd05cbff..7511fad373 100644
--- a/src/box/sql/build.c
+++ b/src/box/sql/build.c
@@ -324,13 +324,6 @@ sqlAddColumn(Parse * pParse, Token * pName, struct type_def *type_def)
pParse->is_aborted = true;
return;
}
- for (uint32_t i = 0; i < def->field_count; i++) {
- if (strcmp(z, def->fields[i].name) == 0) {
- diag_set(ClientError, ER_SPACE_FIELD_IS_DUPLICATE, z);
- pParse->is_aborted = true;
- return;
- }
- }
struct field_def *column_def = &def->fields[def->field_count];
memcpy(column_def, &field_def_default, sizeof(field_def_default));
column_def->name = z;
--
GitLab