From 6d09130711340823b3a82f3fd406661ec8d32c47 Mon Sep 17 00:00:00 2001
From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Mon, 2 Mar 2020 17:46:22 +0300
Subject: [PATCH] popen: log errors if popen creation failed

On error path we arm diag with error but strictly
speaking some users (such as unit tests) do not have
to access diag for logging.

Thus log it explicitly for debug sake.

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
 src/lib/core/popen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lib/core/popen.c b/src/lib/core/popen.c
index ce7d7fff75..806d004bf4 100644
--- a/src/lib/core/popen.c
+++ b/src/lib/core/popen.c
@@ -948,6 +948,7 @@ popen_new(struct popen_opts *opts)
 	return handle;
 
 out_err:
+	diag_log();
 	saved_errno = errno;
 	popen_delete(handle);
 	for (i = 0; i < lengthof(pfd); i++) {
-- 
GitLab