From 674c10581193dc7c5127e33cb995d0dc0ed58a68 Mon Sep 17 00:00:00 2001
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Date: Mon, 5 Feb 2018 11:42:45 +0300
Subject: [PATCH] applier: do not print 'authenticated' message if connecting
as guest
Before commit 2788dc1ba4b2 ("Add APPLIER_READY state") we only printed
the 'authenticated' message to the log in case credentials were set in
the replication URI. The commit changed that: now we print the message
even in case of guest connections, when applier does not send the AUTH
command to the master at all. As a result if guest connections are not
permitted by the master, the applier will keep printing 'authenticated'
after every unsuccessful attempt to subscribe. This is misleading. Let
us revert back to the behavior we had before commit 2788dc1ba4b2.
Closes #3113
---
src/box/applier.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/box/applier.cc b/src/box/applier.cc
index b662fcaa90..93aa8c408f 100644
--- a/src/box/applier.cc
+++ b/src/box/applier.cc
@@ -218,9 +218,9 @@ applier_connect(struct applier *applier)
if (row.type != IPROTO_OK)
xrow_decode_error_xc(&row); /* auth failed */
-done:
/* auth succeeded */
say_info("authenticated");
+done:
applier_set_state(applier, APPLIER_READY);
}
--
GitLab