From 290d5b289c5543e28912a66e62254096c1b3e720 Mon Sep 17 00:00:00 2001 From: Cyrill Gorcunov <gorcunov@gmail.com> Date: Thu, 5 Mar 2020 15:29:36 +0300 Subject: [PATCH] box/txn: rename txn_write to txn_commit_async To reflect the fact tha we're don't waiting for transaction to complete but rely on completion callback. Acked-by: Konstantin Osipov <kostja.osipov@gmail.com> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/box/applier.cc | 2 +- src/box/txn.c | 4 ++-- src/box/txn.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/box/applier.cc b/src/box/applier.cc index ff40e03c6b..8666a3a984 100644 --- a/src/box/applier.cc +++ b/src/box/applier.cc @@ -805,7 +805,7 @@ applier_apply_tx(struct stailq *rows) trigger_create(on_commit, applier_txn_commit_cb, NULL, NULL); txn_on_commit(txn, on_commit); - if (txn_write(txn) < 0) + if (txn_commit_async(txn) < 0) goto fail; /* Transaction was sent to journal so promote vclock. */ diff --git a/src/box/txn.c b/src/box/txn.c index 6799f6c4bb..9f61303ab2 100644 --- a/src/box/txn.c +++ b/src/box/txn.c @@ -558,7 +558,7 @@ txn_prepare(struct txn *txn) } int -txn_write(struct txn *txn) +txn_commit_async(struct txn *txn) { if (txn_prepare(txn) != 0) { txn_rollback(txn); @@ -586,7 +586,7 @@ txn_commit(struct txn *txn) { txn->fiber = fiber(); - if (txn_write(txn) != 0) + if (txn_commit_async(txn) != 0) return -1; /* * In case of non-yielding journal the transaction could already diff --git a/src/box/txn.h b/src/box/txn.h index 7a7e529541..b950e2e188 100644 --- a/src/box/txn.h +++ b/src/box/txn.h @@ -300,7 +300,7 @@ txn_rollback(struct txn *txn); * freed. */ int -txn_write(struct txn *txn); +txn_commit_async(struct txn *txn); /** * Most txns don't have triggers, and txn objects -- GitLab