From 26131a969e4ebfdacb850f8ac643ebdb5b179380 Mon Sep 17 00:00:00 2001
From: EmirVildanov <reddog201030@gmail.com>
Date: Wed, 21 Aug 2024 13:45:21 +0300
Subject: [PATCH] fix: update error message for Reference under Values
---
sbroad-core/src/frontend/sql.rs | 7 +++++++
sbroad-core/src/frontend/sql/ir/tests.rs | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/sbroad-core/src/frontend/sql.rs b/sbroad-core/src/frontend/sql.rs
index 93fee709f..b8402c25c 100644
--- a/sbroad-core/src/frontend/sql.rs
+++ b/sbroad-core/src/frontend/sql.rs
@@ -2218,6 +2218,13 @@ where
}
};
+ if referred_relation_ids.is_empty() {
+ return Err(SbroadError::Invalid(
+ Entity::Expression,
+ Some(format_smolstr!("Reference {first_identifier} met under Values that is unsupported. For string literals use single quotes."))
+ ))
+ }
+
let plan_left_id = referred_relation_ids
.first()
.unwrap_or_else(||
diff --git a/sbroad-core/src/frontend/sql/ir/tests.rs b/sbroad-core/src/frontend/sql/ir/tests.rs
index 58bd07d3a..25fb309ab 100644
--- a/sbroad-core/src/frontend/sql/ir/tests.rs
+++ b/sbroad-core/src/frontend/sql/ir/tests.rs
@@ -3730,7 +3730,7 @@ fn non_existent_references_in_values_do_not_panic() {
assert!(err
.to_string()
- .contains("Reference must point to some relational node"));
+ .contains("Reference \"nonexistent_reference\" met under Values that is unsupported. For string literals use single quotes."));
}
#[test]
--
GitLab