From 9a6cd7332564001640f370a388e6f92f81007f61 Mon Sep 17 00:00:00 2001
From: Georgy Moshkin <gmoshkin@picodata.io>
Date: Mon, 2 Sep 2024 16:59:29 +0300
Subject: [PATCH] chore: add some FIXME comments about stuff that needs to be
done
---
src/plugin/manager.rs | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/plugin/manager.rs b/src/plugin/manager.rs
index c38e59b897..76a6528e27 100644
--- a/src/plugin/manager.rs
+++ b/src/plugin/manager.rs
@@ -281,6 +281,7 @@ impl PluginManager {
.get_by_instance(&instance_id)
.expect("storage should not fail");
let routing_keys: Vec<_> = instance_routes.iter().map(|r| r.key()).collect();
+ // FIXME: this is wrong, use reenterable_plugin_cas_request with correct cas predicate
remove_routes(&routing_keys, Duration::from_secs(10))
.map_err(|traft_err| PluginError::RemoteError(traft_err.to_string()))?;
@@ -301,6 +302,7 @@ impl PluginManager {
ServiceRouteItem::new_healthy(instance_id.clone(), &ident, &svc.lock().name)
})
.collect();
+ // FIXME: this is wrong, use reenterable_plugin_cas_request with correct cas predicate
replace_routes(&items, Duration::from_secs(10))
.map_err(|traft_err| PluginError::RemoteError(traft_err.to_string()))?;
}
@@ -422,6 +424,7 @@ impl PluginManager {
plugin_identity,
service_name,
);
+ // FIXME: this is wrong, use reenterable_plugin_cas_request with correct cas predicate
replace_routes(&[route], Duration::from_secs(10))?;
}
}
@@ -437,6 +440,7 @@ impl PluginManager {
plugin_identity,
service_name,
);
+ // FIXME: this is wrong, use reenterable_plugin_cas_request with correct cas predicate
replace_routes(&[route], Duration::from_secs(10))?;
}
}
@@ -516,6 +520,7 @@ impl PluginManager {
}
}
+ // FIXME: this is wrong, use reenterable_plugin_cas_request with correct cas predicate
replace_routes(&routes_to_replace, Duration::from_secs(10))?;
Ok(())
--
GitLab