From 7f60f51b4d253771ff4d6495148dfb36e72b9a20 Mon Sep 17 00:00:00 2001
From: Igor Kuznetsov <kuznetsovin@gmail.com>
Date: Tue, 6 Sep 2022 13:53:33 +0300
Subject: [PATCH] feat: change sql parser error messages format
---
src/frontend/sql.rs | 2 +-
src/frontend/sql/ast/tests.rs | 11 ++++++-----
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/frontend/sql.rs b/src/frontend/sql.rs
index 57c2951834..be8bc4395b 100644
--- a/src/frontend/sql.rs
+++ b/src/frontend/sql.rs
@@ -42,7 +42,7 @@ impl Ast for AbstractSyntaxTree {
Ok(p) => p,
Err(e) => {
return Err(QueryPlannerError::CustomError(format!(
- "Parsing error: {:?}",
+ "Parsing error: {}",
e
)))
}
diff --git a/src/frontend/sql/ast/tests.rs b/src/frontend/sql/ast/tests.rs
index b60d68ea15..986040efc6 100644
--- a/src/frontend/sql/ast/tests.rs
+++ b/src/frontend/sql/ast/tests.rs
@@ -147,11 +147,12 @@ fn invalid_query() {
let ast = AbstractSyntaxTree::new(query).unwrap_err();
assert_eq!(
format!(
- "{} {} {} {}",
- r#"Parsing error: Error { variant: ParsingError { positives:"#,
- r#"[Alias, Asterisk, True, False, Null, Decimal, Double, Integer, Unsigned, Row, Parameter], negatives: [] },"#,
- r#"location: Pos(7), line_col: Pos((1, 8)), path: None, line: "select a frAm t","#,
- r#"continued_line: None }"#,
+ r#"Parsing error: --> 1:8
+ |
+1 | select a frAm t
+ | ^---
+ |
+ = expected Alias, Asterisk, True, False, Null, Decimal, Double, Integer, Unsigned, Row, or Parameter"#,
),
format!("{}", ast),
);
--
GitLab