From 47efb644f4cfea2e1f10f2d4e93064ff589a4e19 Mon Sep 17 00:00:00 2001
From: Kaitmazian Maksim <m.kaitmazian@picodata.io>
Date: Fri, 31 May 2024 13:15:37 +0300
Subject: [PATCH] fix: return the actual type for min/max functions instead of
scalar
---
sbroad-core/src/ir/expression/types.rs | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/sbroad-core/src/ir/expression/types.rs b/sbroad-core/src/ir/expression/types.rs
index deaa1c89dc..099b677798 100644
--- a/sbroad-core/src/ir/expression/types.rs
+++ b/sbroad-core/src/ir/expression/types.rs
@@ -122,7 +122,24 @@ impl Expression {
Ok(Type::Array)
}
}
- Expression::StableFunction { func_type, .. } => Ok(func_type.clone()),
+ Expression::StableFunction {
+ name,
+ func_type,
+ children,
+ ..
+ } => {
+ // min/max functions have a scalar type, which means that their actual type can be
+ // inferred from the arguments.
+ if let "max" | "min" = name.as_str() {
+ let expr_id = children
+ .first()
+ .expect("min/max functions must have an argument");
+ let expr = plan.get_expression_node(*expr_id)?;
+ expr.calculate_type(plan)
+ } else {
+ Ok(func_type.clone())
+ }
+ }
Expression::CountAsterisk => Ok(Type::Integer),
}
}
--
GitLab